governance: Add member, reviewer and committer roles#43
Conversation
Add three new contributor ladder tiers to the governance document: member, reviewer and committer. All existing maintainers are listed as committers in MAINTAINERS.md. Signed-off-by: Joseph Marrero Corchado <[email protected]>
| issues and pull requests, and their LGTM counts towards the required LGTM count | ||
| to merge a code change into the project. | ||
|
|
||
| Reviewers are part of the organization but do not have write access. Becoming a |
There was a problem hiding this comment.
Is "write" access equivalent to the Github default? As is today "write" implies the ability to e.g. add labels, close issues etc.
Some custom work will be necessary to implement this "can review but almost nothing else" flow. It also feels weird if they can review and hence merge code but not manage issues.
It seems a lot simpler to not create that distinction unless we say a Reviewer can approve a PR from a maintainer, but not an arbitrary other one. That would itself require some custom logic, but makes a bit more sense to me?
Well, I guess this came from containerd, we should try to see how they implement this
There was a problem hiding this comment.
The agent thinks we can do something like:
- Create two GitHub teams in the bootc-dev org: e.g. committers and reviewers
- Give both teams Write access to repos
- Enable branch protection on main with "Restrict who can push to matching branches" and only add the committers team
- Reviewers can approve PRs and their approval satisfies the "required approvals" check, but only Committers can click merge / add to merge queue
But I need to check this on my own org/repos.
There was a problem hiding this comment.
containerd also uses kubernetes-prow so that might be doing some of the heavy lifting too.
|
Tagging in that there's more discussion in #22 |
|
Let's just use #22 for this. |
3 participants
Add three new contributor ladder tiers to the governance document: member, reviewer and committer. All existing maintainers are listed as committers in MAINTAINERS.md.
This was drafted using Opus 4.6 and with https://kubernetes.io/docs/contribute/participate/roles-and-responsibilities/ & https://github.com/containerd/.project/blob/main/GOVERNANCE.md as examples. Iterated a bit to make sure Opus did not rewrite everything and just added the relevant sections.
DRAFT while we discuss